handleIsCompositeIdentifier in uml22 metafacade EntityLogicImpl was broken in #15083

Description

Code style cleanup in change #15083 caused a logic error in handleIsCompositeIdentifier such that <<Identifier>> attributes are no longer working

Environment

Any

Activity

Show:
Bob Fields
July 14, 2011, 2:07 AM

I don't know why an additional set of parenthesis would cause the if ? : to no longer work, but the suggested changes looked like it wouldn't break anything, so I committed the patch. Awaiting word as to if this fixes the problem.

Jason Northcote
July 14, 2011, 3:39 AM

It wasn't the parenthesis. When the expression arguments swapped positions the ! should have been removed as well.

Bob Fields
July 15, 2011, 9:04 PM

D'oh. I see now. I committed the change with the ! removed, should work now, let me know.

Jason Northcote
July 19, 2011, 2:05 AM

Looks good to me

Assignee

Former user

Reporter

Jason Northcote

Labels

None

Components

Affects versions

Priority

Major
Configure